Project

General

Profile

Actions

Bug #396

closed

Memory leak in batadv_tt_global_add

Added by Martin Weinelt over 5 years ago. Updated over 4 years ago.

Status:
Rejected
Priority:
Normal
Target version:
-
Start date:
07/13/2019
Due date:
% Done:

0%

Estimated time:

Description

Hi,

on 5.2.0-rc7+ with batman-adv v2019.2-1-gc92331e0 I'm occasionally seeing
the following with kmemleak:

unreferenced object 0xffff8b1557cc9480 (size 128):
  comm "softirq", pid 0, jiffies 4298398929 (age 22408.132s)
  hex dump (first 32 bytes):
    f4 f2 6d 85 c1 7c 00 80 00 00 00 00 00 00 00 00  ..m..|..........
    d0 8b ec 55 15 8b ff ff 00 00 00 00 00 00 00 00  ...U............
  backtrace:
    [<000000006e2c9ed6>] batadv_tt_global_add+0x5fa/0x630 [batman_adv]
unreferenced object 0xffff8b1559c9fa80 (size 64):
  comm "softirq", pid 0, jiffies 4298398929 (age 22408.132s)
  hex dump (first 32 bytes):
    00 16 4a 3a 15 8b ff ff 00 00 00 00 00 00 00 00  ..J:............
    00 00 00 00 00 00 00 00 c0 94 cc 57 15 8b ff ff  ...........W....
  backtrace:
[<000000002053c4bb>] batadv_tt_global_add+0x53c/0x630 [batman_adv]

I've looked up the function offsets:

batadv_tt_global_add+0x5fa/0x630:
batadv_tt_global_add at /var/lib/dkms/batman-adv/v2019.2-1-gc92331e0/build/net/batman-adv/translation-table.c:1711

batadv_tt_global_add+0x53c/0x630:
batadv_tt_global_orig_entry_add at /var/lib/dkms/batman-adv/v2019.2-1-gc92331e0/build/net/batman-adv/translation-table.c:1637
(inlined by) batadv_tt_global_add at /var/lib/dkms/batman-adv/v2019.2-1-gc92331e0/build/net/batman-adv/translation-table.c:1801
Actions #1

Updated by Marek Lindner over 4 years ago

  • Status changed from New to Closed
  • Target version set to 2020.2
<marec> checked the git history and we did have some memleak fixes related to TT
<hexa-> not running kmemleak anymore, so tough to say
<hexa-> but our systems don't seem leaky at this time
Actions #2

Updated by Sven Eckelmann over 4 years ago

  • Status changed from Closed to Rejected
  • Target version deleted (2020.2)

There wasn't a TT memory leak fix in 2020.2. There was also non between v2019.2 and v2020.2 as far as I can see. So mark it as rejected in case you think that it is invalid

Actions

Also available in: Atom PDF