Bug #188
closedlogspam "net_ratelimit: X callbacks suppressed"
0%
Description
The batman-adv module currently produces a lot of logspam of the form
[107051.330000] net_ratelimit: 44 callbacks suppressed [107325.800000] net_ratelimit: 88 callbacks suppressed [107585.650000] net_ratelimit: 23 callbacks suppressed
This is caused by the definition of net_ratelimited_function in compat.h because net_ratelimit() is called independent of the current debug level. Thus net_ratelimit() prints the above messages although the actual message would not be printed.
The issue can be fixed trivially by calling net_ratelimit() after the debug level has been checked.
Updated by Marek Lindner over 10 years ago
Do you mind taking the next step and send a patch to the mailing list ? Seems you have analyzed the problem already ..
Updated by André Gaul over 10 years ago
Yes, I can take some minutes later today. I'm not very familiar with the batman-adv code yet, but this definitely is a low-hanging fruit... ;)
Updated by André Gaul over 10 years ago
I prepared a patch, see https://github.com/andrenarchy/batman-adv/commit/30ff8cf671a84875b2605c3cb5103639979763d4 .
It's not yet tested. Can you review the code? Thx!
Updated by Marek Lindner over 10 years ago
Typically, patches are sent to the mailing list for review. For more information see the 'submitting patches' section here: Contribute
Updated by André Gaul over 10 years ago
The patch was submitted to the mailing list, cf. https://patchwork.open-mesh.org/project/b.a.t.m.a.n./patch/1402334059-28681-1-git-send-email-gaul@web-yard.de/
Updated by Marek Lindner almost 10 years ago
- Status changed from New to Closed
Has been merged. Thanks!